Skip to content

[Devtools] Update Readme Links#45

Merged
Jdubrick merged 2 commits into
devfile-samples:mainfrom
Jdubrick:readme-update
Mar 1, 2024
Merged

[Devtools] Update Readme Links#45
Jdubrick merged 2 commits into
devfile-samples:mainfrom
Jdubrick:readme-update

Conversation

@Jdubrick

Copy link
Copy Markdown
Contributor

This PR updates the README so that the links direct the user to the correct block of code. Previous to this PR some links were containing irrelevant lines of code.

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>

@michael-valdron michael-valdron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to revise v2 branch with these corrections as well: https://github.com/devfile-samples/devfile-sample-python-basic/tree/v2.0.0

Comment thread README.md Outdated
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
@michael-valdron

michael-valdron commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

You'll need to revise v2 branch with these corrections as well: https://github.com/devfile-samples/devfile-sample-python-basic/tree/v2.0.0

I re-mend my original request for the v2 branch changes, since the setup on the v2 branch is different we'll need a rewrite to explain the v2 setup with the reference links pointing to the v2 branch files or parent devfile.

cc: @Jdubrick

@michael-valdron michael-valdron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Jdubrick Jdubrick merged commit 61e1983 into devfile-samples:main Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants